Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DBTypes that are missing for TypeMapping #6463

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

patrick1100
Copy link
Contributor

Q A
Type bug
Fixed issues #6259

Summary

We've got error because of missing DBTypes on SQLSRV. "Unknown database type sysname requested, Doctrine\DBAL\Platforms\SQLServer2012Platform may not support it.". Once for 'sysname' and for 'xml'.

@derrabus
Copy link
Member

derrabus commented Jul 3, 2024

Thank you. Please add a functional test that covers your issue.

@patrick1100
Copy link
Contributor Author

patrick1100 commented Jul 5, 2024

There was anything wrong with codecov

error - 2024-07-04 12:10:54,906 -- Report creating failed: {"detail":"Not valid tokenless upload"}
Error: Codecov:
Failed to properly create report: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code

maybe restart the checks?

@greg0ire
Copy link
Member

greg0ire commented Jul 5, 2024

It's a known issue: codecov/codecov-action#1487

SenseException
SenseException previously approved these changes Jul 14, 2024
@derrabus derrabus changed the base branch from 3.8.x to 3.9.x August 14, 2024 10:49
@derrabus derrabus dismissed SenseException’s stale review August 14, 2024 10:49

The base branch was changed.

@derrabus derrabus added this to the 3.9.0 milestone Aug 14, 2024
@derrabus derrabus merged commit 677746e into doctrine:3.9.x Aug 14, 2024
91 of 92 checks passed
derrabus added a commit to derrabus/dbal that referenced this pull request Aug 14, 2024
* 3.9.x:
  fix doctrine#6198:  stop considering generated column definition as being its default value (doctrine#6199)
  Fix condition on Ascii String for SQL Server (doctrine#6389)
  Add DBTypes that are missing for TypeMapping (doctrine#6463)
derrabus added a commit to derrabus/dbal that referenced this pull request Aug 14, 2024
* 3.9.x:
  fix doctrine#6198:  stop considering generated column definition as being its default value (doctrine#6199)
  Fix condition on Ascii String for SQL Server (doctrine#6389)
  Add DBTypes that are missing for TypeMapping (doctrine#6463)
derrabus added a commit to derrabus/dbal that referenced this pull request Aug 14, 2024
* 3.9.x:
  fix doctrine#6198:  stop considering generated column definition as being its default value (doctrine#6199)
  Fix condition on Ascii String for SQL Server (doctrine#6389)
  Add DBTypes that are missing for TypeMapping (doctrine#6463)
derrabus added a commit that referenced this pull request Aug 15, 2024
* 4.1.x:
  Prepare 3.9.0 and 4.1.0 (#6492)
  Deprecate support for Postgres 10 and 11 (#6495)
  Document the new PostgreSQL120Platform (#6494)
  fix #6198:  stop considering generated column definition as being its default value (#6199)
  Fix condition on Ascii String for SQL Server (#6389)
  Add DBTypes that are missing for TypeMapping (#6463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants